Stable tests#188
Merged
Merged
Conversation
Member
Author
|
Okay, I wasn't actually running ignored tests locally, so that's part of the problem. Still fishy... |
ctz
approved these changes
Jul 8, 2026
ctz
left a comment
ctz
left a comment
Member
There was a problem hiding this comment.
I think this is alright -- the error that looks like:
result disagrees between high-level API (IncorrectlyNotRevoked) and rustls verifier (Expired)
This means the certificate is really expired, and has fallen out of the revocation set as a result. That means the blanket treat-expired-as-revoked flattening no longer works.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There have been some failures in CI that I was unable to reproduce locally. Try to stabilize the system tests.
(With help from Claude; I think both of these are good fixes but not sure if they explain away disparities between CI and my local setup.)